perf: faster ament_libraries_deduplicate implementation

[VRichardJP]

A faster implementation of ament_libraries_deduplicate().
See #447

Also related: #442

[VRichardJP]

@sloretz any update?

[xmfcx]

@VRichardJP could you rebase this branch onto latest humble branch?(27ce75b)

We will use your PR branch within the Autoware project through:

• feat(autoware.repos): add fork of ament_cmake for faster build autowarefoundation/autoware#4141

[cottsay]

Hi @VRichardJP.

Would you mind merging or rebasing to include the latest changes in the rolling branch, as well as updating your sign-off to please the DCO bot? It says:

Expected "Vincent Richard <[email protected]>", but got "Vincent Richard <[email protected]>".

The sign-off needs to match the commit author.

[VRichardJP]

@cottsay done!

[cottsay]

Looks like the tests I added for ament_libraries_deduplicate are failing. It appears this change modifies the behavior of the function under some conditions.

We will need to either re-align the behavior or sufficiently explain why the new behavior is more correct.

[VRichardJP]

Nice catch
I think the regex is fixed now.

Before:

$ cmake -P ament_cmake_libraries/test/test_deduplicate.cmake 
CMake Error at ament_cmake_libraries/test/utilities.cmake:6 (message):
  Assert failed: Expected 'debug;foo;debug;baz;debug;bar', got
  'debug;foo;baz;debug;bar'
Call Stack (most recent call first):
  ament_cmake_libraries/test/test_deduplicate.cmake:21 (assert_equal)


CMake Error at ament_cmake_libraries/test/utilities.cmake:6 (message):
  Assert failed: Expected 'debug;foo;debug;bar;debug;baz;bar', got
  'debug;foo;debug;baz;bar'
Call Stack (most recent call first):
  ament_cmake_libraries/test/test_deduplicate.cmake:26 (assert_equal)


CMake Error at ament_cmake_libraries/test/utilities.cmake:6 (message):
  Assert failed: Expected 'debug;foo;debug;bar;debug;baz;release;bar', got
  'debug;foo;debug;baz;release;bar'
Call Stack (most recent call first):
  ament_cmake_libraries/test/test_deduplicate.cmake:31 (assert_equal)

After: no error

[VRichardJP]

@cottsay by the way, in your test you use the "release" keyword, but I don't think it is used in the original code

see https://github.com/ament/ament_cmake/pull/448/files#diff-c2367dcaba4bcc1d6bd25ee305a50f29b844d0555aa0f595b57d877d371abe31L33

[cottsay]

you use the "release" keyword, but I don't think it is used in the original code

Well spotted! Please feel free to change that to one of the supported keywords.

[VRichardJP]

@cottsay maybe it make more sense to have this in a different PR, as this one focuses on performance only.

[cottsay]

maybe it make more sense to have this in a different PR, as this one focuses on performance only

Sure, #516

[cottsay]

• Linux
• Linux-aarch64
• Linux-RHEL
• Windows

[sloretz]

Thank you for the PR!