Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence compiler and clippy warnings… #254

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

ImmemorConsultrixContrarie
Copy link
Contributor

Description

… by doing what compiler and clippy say to do.

Motivation and Context

I don't like seeing warnings.

How Has This Been Tested?

cargo +nightly clippy && cargo test

Checklist:

  • Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.
  • My code follows the code style of this project.
  • If my change required a change to the documentation I have updated the documentation accordingly.
  • I have updated the content of the book if this PR would make the book outdated.
  • I have added tests to cover my changes.
  • My code is used in an example.

@ImmemorConsultrixContrarie
Copy link
Contributor Author

#249, #250, #251, #252 and #255 failed CI due to compiler warnings (which this PR silenced), not actual problems. For the last two of them it is even worse, because it is failed beta that cancelled almost all other tests, not just failed nightly.
Could someone do something with warnings (merge this PR, write and merge another PR, etc.) and rerun CI for those fails?

@TomGillen
Copy link
Collaborator

These PRs are only failing CI on nightly (which we allow). New checks added to nightly clippy can happen without warning and will cause spurious CI failures. We should probably remove clippy from the nightly builds in CI.

@TomGillen
Copy link
Collaborator

bors r+

@TomGillen TomGillen added the type: maintenance A task that has no noticeable user-facing effect. Code cleanup, small refactors, etc label Apr 7, 2021
@bors bors bot merged commit dfafc49 into amethyst:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance A task that has no noticeable user-facing effect. Code cleanup, small refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants