Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cuda-cupti and cuda-nvcc run dependencies for pixi #138

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove cuda-cupti and cuda-nvcc run dependencies for pixi #138

merged 1 commit into from
Apr 16, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Apr 16, 2024 •
edited by github-actions bot
Loading

This PR removes the aforementioned dependencies from the pixi section of pyproject.toml. Given that conda-forge/jaxlib-feedstock#241 has been merged, they are not needed anymore

📚 Documentation preview 📚: https://jaxsim--138.org.readthedocs.build//138/

@flferretti
Remove cuda-cupti and cuda-nvcc dependency for pixi
b4c5c7d 
Given that conda-forge/jaxlib-feedstock#241 has been merged, they are not needed anymore
@flferretti flferretti requested a review from traversaro April 16, 2024 08:23
@flferretti flferretti self-assigned this Apr 16, 2024
@flferretti flferretti requested a review from diegoferigo as a code owner April 16, 2024 08:23
diegoferigo
diegoferigo approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's proceed without updating the pixi.lock file. We currently have two of them, but ideally I'd like to maintain only one.

@flferretti
Copy link
Collaborator Author

Let's proceed without updating the pixi.lock file. We currently have two of them, but ideally I'd like to maintain only one.

I can open a separate PR for that

@flferretti flferretti merged commit a6544fb into main Apr 16, 2024
24 checks passed
@flferretti flferretti deleted the flferretti-patch-1 branch April 16, 2024 08:48
@traversaro
Copy link
Contributor

This was removing cuda-cupti too soon, see conda-forge/jaxlib-feedstock#241 (comment) and conda-forge/cuda-cupti-feedstock#14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@diegoferigo diegoferigo diegoferigo approved these changes

Assignees

@flferretti flferretti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flferretti @traversaro @diegoferigo