Adjust the variable parsing for vrb argument
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… putative input types
|
Not merging this yet, because the proposed solution should first work in all |
hanneoberman
approved these changes
Jul 26, 2024
hanneoberman
changed the title
vrb argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the way the
vrbargument is parsed forplot_trace(). In particular, it makes the function work when an external object is supplied as the function argument. In such cases, the object name will need to be unquoted using!!. I've attempted to align the implementation with standard Tidy Evaluation principles. Hence, requiring the!!-based unquoting rather than adjustingplot_trace()to gobble up all sensible inputs.The documentation and unit tests should reflect the relevant changes.
This PR should fix #145.