Skip to content

Commit

Permalink
Update cran-comments for mice 3.14.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@stefvanbuuren
stefvanbuuren committed Nov 23, 2021
1 parent f89a8b8 commit 7591706
Show file tree
Hide file tree
Showing 2 changed files with 89 additions and 138 deletions.
110 changes: 42 additions & 68 deletions cran-comments.Rmd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ output: github_document
knitr::opts_chunk$set(echo = TRUE)
```

## mice 3.13.0
## mice 3.14.0

New submission.

## Reason

After signal sent by Brian Ripley on Jan26. `mice 3.13.0` implements a fix for a bug that produced errors with `mitml 0.4-0`.
A report from CRAN indicates that `install.on.demand()` breaks the CRAN work flow, so an urgent update is needed. In addition, there are many changes and improvements since the last CRAN version 3.13.0 published in Jan 2021.

## Test environments

* local OS X install, 11.11, R 4.0.3
* local OS X install, 11.6, R 4.1.2
* win-builder
* Rhub

Expand All @@ -31,15 +31,14 @@ build()
```

```{bash eval=FALSE}
R CMD CHECK mice_3.13.0.tar.gz
R CMD CHECK mice_3.14.0.tar.gz
```


Status: OK

## win-builder

```r
```{r eval=FALSE}
devtools::check_win_devel()
```

Expand All @@ -49,15 +48,14 @@ Status: OK
## Rhub checks

```{r eval=FALSE}
check_rhub()
devtools::check_rhub()
```

Results:

1. Debian Linux, R-devel, GCC ASAN/UBSAN: Error, compilation failed for package `miceadds`
2. Windows Server 2008 R2 SP1, R-devel, 32/64 bit: Finished: SUCCESS
1. Debian Linux, R-devel, GCC ASAN/UBSAN: Success
3. Ubuntu Linux 20.04.1 LTS, R-release, GCC: Success
4. Fedora Linux, R-devel, clang, gfortran: Success, with four (benign) warnings about CPU time for examples
4. Fedora Linux, R-devel, clang, gfortran: Success


## Downstream dependencies
Expand All @@ -75,66 +73,42 @@ revdep_check(num_workers = 10)
There is one old failure (`dynr`): `configure: error: gsl-config not found, is GSL installed?`
Not related to `mice`.

### `problems.md`

*Wow, no problems at all. :)*

### README.md
### `problems.md`

```
# Platform
|field |value |
|:--------|:----------------------------|
|version |R version 4.0.3 (2020-10-10) |
|os |macOS Big Sur 10.16 |
|system |x86_64, darwin17.0 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |Europe/Amsterdam |
|date |2021-01-26 |
# Dependencies
|package |old |new |Δ |
|:----------|:------|:------|:--|
|mice |3.12.0 |3.13.0 |* |
|assertthat |0.2.1 |0.2.1 | |
|backports |1.2.1 |1.2.1 | |
|broom |0.7.3 |0.7.3 | |
|cli |2.2.0 |2.2.0 | |
|cpp11 |0.2.5 |0.2.5 | |
|crayon |1.3.4 |1.3.4 | |
|digest |0.6.27 |0.6.27 | |
|dplyr |1.0.3 |1.0.3 | |
|ellipsis |0.3.1 |0.3.1 | |
|fansi |0.4.2 |0.4.2 | |
|generics |0.1.0 |0.1.0 | |
|glue |1.4.2 |1.4.2 | |
|lifecycle |0.2.0 |0.2.0 | |
|magrittr |2.0.1 |2.0.1 | |
|pillar |1.4.7 |1.4.7 | |
|pkgconfig |2.0.3 |2.0.3 | |
|purrr |0.3.4 |0.3.4 | |
|R6 |2.5.0 |2.5.0 | |
|Rcpp |1.0.6 |1.0.6 | |
|rlang |0.4.10 |0.4.10 | |
|stringi |1.5.3 |1.5.3 | |
|stringr |1.4.0 |1.4.0 | |
|tibble |3.0.5 |3.0.5 | |
|tidyr |1.1.2 |1.1.2 | |
|tidyselect |1.1.0 |1.1.0 | |
|utf8 |1.1.4 |1.1.4 | |
|vctrs |0.3.6 |0.3.6 | |
# Revdeps
## Failed to check (1)
|package |version |error |warning |note |
|:-------|:---------|:-----|:-------|:----|
|dynr |0.1.15-25 |1 | | |
# CALIBERrfimpute
<details>
* Version: 1.0-5
* GitHub: NA
* Source code: https://github.com/cran/CALIBERrfimpute
* Date/Publication: 2021-05-05 09:00:04
* Number of recursive dependencies: 53
Run `revdep_details(, "CALIBERrfimpute")` for more info
</details>
## Newly broken
* checking running R code from vignettes ...
‘simstudy_survival.Rnw’ using ‘UTF-8’... failed
ERROR
Errors in running code in vignettes:
when running code in ‘simstudy_survival.Rnw’
...
x2 & 0.0391 & 0.0254 & 0.0138 \\
x3 & -0.0314 & -0.00854 & -0.0228 \\
\hline
\end{tabular}
\vspace{1em}
When sourcing ‘simstudy_survival.R’:
Error: missing value where TRUE/FALSE needed
Execution halted
```

Not sure whether it's related to `mice`, and seems relatively benign if it is. The package maintainer of `CALIBERrfimpute` is aware of the problem, and will look into the issue.
117 changes: 47 additions & 70 deletions cran-comments.md
View file
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
cran-comments
================

## mice 3.13.0
## mice 3.14.0

New submission.

## Reason

After signal sent by Brian Ripley on Jan26. `mice 3.13.0` implements a
fix for a bug that produced errors with `mitml 0.4-0`.
A report from CRAN indicates that `install.on.demand()` breaks the CRAN
work flow, so an urgent update is needed. In addition, there are many
changes and improvements since the last CRAN version 3.13.0 published in
Jan 2021.

## Test environments

- local OS X install, 11.11, R 4.0.3
- local OS X install, 11.6, R 4.1.2
- win-builder
- Rhub

Expand All @@ -26,7 +28,7 @@ build()
```

``` bash
R CMD CHECK mice_3.13.0.tar.gz
R CMD CHECK mice_3.14.0.tar.gz
```

Status: OK
Expand All @@ -42,17 +44,14 @@ Status: OK
## Rhub checks

``` r
check_rhub()
devtools::check_rhub()
```

Results:

1. Debian Linux, R-devel, GCC ASAN/UBSAN: Error, compilation failed for
package `miceadds`
2. Windows Server 2008 R2 SP1, R-devel, 32/64 bit: Finished: SUCCESS
3. Ubuntu Linux 20.04.1 LTS, R-release, GCC: Success
4. Fedora Linux, R-devel, clang, gfortran: Success, with four (benign)
warnings about CPU time for examples
1. Debian Linux, R-devel, GCC ASAN/UBSAN: Success
2. Ubuntu Linux 20.04.1 LTS, R-release, GCC: Success
3. Fedora Linux, R-devel, clang, gfortran: Success

## Downstream dependencies

Expand All @@ -72,61 +71,39 @@ to `mice`.

### `problems.md`

*Wow, no problems at all. :)*

### README.md

# Platform

|field |value |
|:--------|:----------------------------|
|version |R version 4.0.3 (2020-10-10) |
|os |macOS Big Sur 10.16 |
|system |x86_64, darwin17.0 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |Europe/Amsterdam |
|date |2021-01-26 |

# Dependencies

|package |old |new |Δ |
|:----------|:------|:------|:--|
|mice |3.12.0 |3.13.0 |* |
|assertthat |0.2.1 |0.2.1 | |
|backports |1.2.1 |1.2.1 | |
|broom |0.7.3 |0.7.3 | |
|cli |2.2.0 |2.2.0 | |
|cpp11 |0.2.5 |0.2.5 | |
|crayon |1.3.4 |1.3.4 | |
|digest |0.6.27 |0.6.27 | |
|dplyr |1.0.3 |1.0.3 | |
|ellipsis |0.3.1 |0.3.1 | |
|fansi |0.4.2 |0.4.2 | |
|generics |0.1.0 |0.1.0 | |
|glue |1.4.2 |1.4.2 | |
|lifecycle |0.2.0 |0.2.0 | |
|magrittr |2.0.1 |2.0.1 | |
|pillar |1.4.7 |1.4.7 | |
|pkgconfig |2.0.3 |2.0.3 | |
|purrr |0.3.4 |0.3.4 | |
|R6 |2.5.0 |2.5.0 | |
|Rcpp |1.0.6 |1.0.6 | |
|rlang |0.4.10 |0.4.10 | |
|stringi |1.5.3 |1.5.3 | |
|stringr |1.4.0 |1.4.0 | |
|tibble |3.0.5 |3.0.5 | |
|tidyr |1.1.2 |1.1.2 | |
|tidyselect |1.1.0 |1.1.0 | |
|utf8 |1.1.4 |1.1.4 | |
|vctrs |0.3.6 |0.3.6 | |

# Revdeps

## Failed to check (1)

|package |version |error |warning |note |
|:-------|:---------|:-----|:-------|:----|
|dynr |0.1.15-25 |1 | | |
# CALIBERrfimpute

<details>

* Version: 1.0-5
* GitHub: NA
* Source code: https://github.com/cran/CALIBERrfimpute
* Date/Publication: 2021-05-05 09:00:04
* Number of recursive dependencies: 53

Run `revdep_details(, "CALIBERrfimpute")` for more info

</details>

## Newly broken

* checking running R code from vignettes ...
‘simstudy_survival.Rnw’ using ‘UTF-8’... failed
ERROR
Errors in running code in vignettes:
when running code in ‘simstudy_survival.Rnw’
...
x2 & 0.0391 & 0.0254 & 0.0138 \\
x3 & -0.0314 & -0.00854 & -0.0228 \\
\hline
\end{tabular}
\vspace{1em}
When sourcing ‘simstudy_survival.R’:
Error: missing value where TRUE/FALSE needed
Execution halted

Not sure whether it’s related to `mice`, and seems relatively benign if
it is. The package maintainer of `CALIBERrfimpute` is aware of the
problem, and will look into the issue.

0 comments on commit 7591706

Please sign in to comment.