Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for cron syntax #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JeffLuckett
Copy link

@JeffLuckett JeffLuckett commented May 22, 2019

Uses Fugit gem to provide support for cron syntax for scheduling.

Also fixes your Travis build for older rubies.

@afn
Copy link
Contributor

afn commented Jun 3, 2019

This is a cool feature, but I'd like to avoid adding a dependency unnecessarily. Can you modify this to
just require fugit on demand if the cron option is used, and fail with an appropriate error message if the user doesn't have the gem installed?

We should also have test coverage (it's fine to include fugit as a development dependency).

Finally, since the cron setting overrides causes run_at, run_interval, and tz to be ignored, we should make these mutually exclusive by raising an error if both cron and one of the other settings is set.

@JeffLuckett
Copy link
Author

JeffLuckett commented Jun 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants