-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve navigation cpp #1061
Open
CyAn84
wants to merge
94
commits into
dev
Choose a base branch
from
improve_navigation_cpp
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve navigation cpp #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyAn84
force-pushed
the
improve_navigation_cpp
branch
10 times, most recently
from
September 21, 2024 22:28
6d31502
to
221acc1
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
2 times, most recently
from
October 2, 2024 18:36
d12a16d
to
63cadb3
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
October 9, 2024 21:13
63cadb3
to
0fcfa0c
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
October 17, 2024 02:15
0fcfa0c
to
040b8f8
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
5 times, most recently
from
October 25, 2024 14:55
0f79ad5
to
78ec451
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
October 26, 2024 18:09
78ec451
to
39716d6
Compare
aiamnezia
reviewed
Oct 30, 2024
aiamnezia
reviewed
Oct 30, 2024
CyAn84
force-pushed
the
improve_navigation_cpp
branch
2 times, most recently
from
October 30, 2024 15:52
850ab1c
to
7b0713b
Compare
aiamnezia
reviewed
Oct 31, 2024
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
November 1, 2024 07:28
433d02f
to
58b0e80
Compare
Nethius
reviewed
Dec 16, 2024
Nethius
reviewed
Dec 18, 2024
Nethius
reviewed
Dec 18, 2024
focus control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still draft pull request since the transitions need to be fixed.
The idea of navigation is follow:
there are QML components which should be focused with property
isFocusable
with key Tab handlers,focusController
goes through all visible components with this property.No need to describe the focus logic manually but the focus navigation algorythm is straightforward - from upper left to bottom right.