feature/mozilla upstream #1237
Draft
feature/mozilla upstream #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outspace
reviewed
Dec 24, 2024
| @@ -236,17 +262,6 @@ bool WindowsFirewall::enablePeerTraffic(const InterfaceConfig& config) { | |||
| } | |||
| } | |||
|
|
|||
| if (!config.m_excludedAddresses.empty()) { | |||
There was a problem hiding this comment.
We need this part for splittunnel excluded sites
outspace
reviewed
Dec 24, 2024
| @@ -484,57 +549,6 @@ bool WindowsFirewall::allowTrafficTo(const QHostAddress& targetIP, uint port, | |||
| return true; | |||
| } | |||
|
|
|||
| bool WindowsFirewall::allowTrafficToRange(const IPAddress& addr, uint8_t weight, | |||
There was a problem hiding this comment.
Split tunnel supports routes with network mask. That's why we rewrite default "allowTraffic".
outspace
reviewed
Dec 24, 2024
| } | ||
| if (InetPtonW(AF_INET6, ipv6.c_str(), out_ipv6) != 1) { | ||
| logger.debug() << "Ipv6 Conversation error" << WSAGetLastError(); | ||
| return false; |
There was a problem hiding this comment.
Not sure about this part. It breaks app split tunnel when ipv6 is not setup.
We can just ignore when ipv6 address is not setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.