Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

92 clean up task technical debt clean up #118

Merged
merged 16 commits into from
Dec 3, 2024
Merged

92 clean up task technical debt clean up #118

merged 16 commits into from
Dec 3, 2024

Conversation

Omega65536
Copy link
Contributor

All TODOs done:

  • Switch to decimal numbers (frontend, backend, analyzer) (have noticed there are also some backups < 1 MB)
  • Check for duplicate alarms in the backend
  • alarmLimit should be optional QueryParam according to REST style
  • We need an env variable in the backend to activate/deactivate the mailing, otherwise it's super annoying
  • Actually, the analyzer should only check new backups that have not yet been checked:
    The backend offers an API to query the last alert created for a specific alert type and backup type. The analyzer only sends alerts for new backups created after that time.
  • Do not only import FULL backups, so that alerts can also be linked to them. But do not deliver them to the frontend

heskil and others added 16 commits November 29, 2024 15:45
@heskil
changed alert limit to optional query parameter
801fe5e 
Signed-off-by: Amelie Regl <[email protected]>
@heskil
added swagger definition for basic analysis endpoints
23f23f5 
Signed-off-by: Amelie Regl <[email protected]>
@flo0852
Merge remote-tracking branch 'origin/dev' into 92-clean-up-task-techn…
6e727c6 
…ical-debt-clean-up

# Conflicts:
#	apps/analyzer/metadata_analyzer/simple_rule_based_analyzer.py
@flo0852
Added endpoint and logic to get date of latest backup for alert type
fc02a5b 
Signed-off-by: Florian Oberndörfer <[email protected]>
@flo0852
small improvements
a6dfbf5 
Signed-off-by: Florian Oberndörfer <[email protected]>
@flo0852
changed Endpoint for latest alert backup to return id
3410ae4 
Signed-off-by: Florian Oberndörfer <[email protected]>
@flo0852
added apiTags for swagger
4f3e9d8 
Signed-off-by: Florian Oberndörfer <[email protected]>
@flo0852
Merge remote-tracking branch 'origin/dev' into 92-clean-up-task-techn…
e20823d 
…ical-debt-clean-up

# Conflicts:
#	apps/backend/src/app/alerting/alerting.controller.ts
@Omega65536
Change analyzer to only analyze results which haven't been analyzed yet
f35f617 
Signed-off-by: Oliver Schnell <[email protected]>
@engelharddirk
remove unused dependeny
8be1edd 
Signed-off-by: engelharddirk <[email protected]>
@Omega65536
Add tests and bugfixes
40c695c 
Signed-off-by: Oliver Schnell <[email protected]>
@Omega65536
Merge branch '92-clean-up-task-technical-debt-clean-up' of github.com…
bc6ae37 
…:amosproj/amos2024ws02-backup-metadata-analyzer into 92-clean-up-task-technical-debt-clean-up
@engelharddirk
move frontend testrunner to dev dependencies
7b406fa 
Signed-off-by: engelharddirk <[email protected]>
@Omega65536
Also send non full backups to the backend with their correct type, ad…
7eee755 
…d tests for this

Signed-off-by: Oliver Schnell <[email protected]>
@flo0852
Merge remote-tracking branch 'origin/dev' into 92-clean-up-task-techn…
cf281a6 
…ical-debt-clean-up

# Conflicts:
#	apps/backend/src/app/alerting/alerting.controller.ts
#	apps/backend/src/app/alerting/alerting.service.ts
@flo0852
Merge
a5ad607 
Signed-off-by: Florian Oberndörfer <[email protected]>
@heskil heskil self-requested a review December 3, 2024 11:13
heskil
heskil approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@heskil heskil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that were not authored by me are appropriate and cleaner than before. Further changes are needed for correctly implementing analysis of only new data, but that will be adressed next sprint.

@Omega65536
Copy link
Contributor Author

I reviewed the code written by @heskil. The changes meet the requirements and the code looks great.

@Omega65536 Omega65536 merged commit 3f449a7 into dev Dec 3, 2024
2 checks passed
@flo0852 flo0852 deleted the 92-clean-up-task-technical-debt-clean-up branch December 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heskil heskil heskil approved these changes

Assignees

@Omega65536 Omega65536

@heskil heskil

@flo0852 flo0852

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Omega65536 @heskil @flo0852 @engelharddirk