Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 GitHub actions backend and analyzer test automation #80

Merged
merged 13 commits into from
Nov 26, 2024

Conversation

ddeli
Copy link
Collaborator

@ddeli ddeli commented Nov 26, 2024

Added Github actions pipline for automated tests. had to comment out two backend tests in backupData.service.spec.ts to make it run

@ddeli
Copy link
Collaborator Author

ddeli commented Nov 26, 2024

I just saw that i need to adjust the target branch. I will do that as soon as i get confirmation that all backend and analyzer tests under development are running local and are merged to dev

Signed-off-by: Deniz Deli <[email protected]>
@heskil heskil self-requested a review November 26, 2024 17:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these commented out sections necessary? If not then I think it would be better practice to remove them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are definitely necessary but are currently failing. In order to build my test runner, I have commented them out for now. They must be fixed or removed in the next sprint

Copy link
Contributor

@heskil heskil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ddeli ddeli merged commit bc288cf into dev Nov 26, 2024
2 checks passed
@flo0852 flo0852 deleted the 32-github-actions-backend-and-analyzer-test-automation branch December 5, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants