Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding symbols from oat/dex files #143

Merged
merged 17 commits into from
Dec 9, 2024
Merged

Conversation

Mr-Kanister
Copy link
Contributor

@Mr-Kanister Mr-Kanister commented Dec 4, 2024

We are now able to get a list of all .odex files related to a specified pid.

With a then selected .odex file it is further possible to get a list of all compiled (that is with offset != 0) symbols out of that .odex file. The method names get supplied together with the offsets.

With the desired method and offset filtered out of the list, it will then be possible to attach a uProbe onto the symbol.

As a sidequest the daemon/bin/cli.rs client got remove as it was unnecessary. The (better) client/bin/cli.rs client got extended to support the mentioned changes and got an overall polish. There are now multiple subcommands which can be viewed via cargo xtask client -- help. Each subcommand has it's own help page via cargo xtask client -- <SUBCOMMAND> --help as well.

The (not intended) sidequest should have been outsourced to a different issue, but well...

Closes #117

@Mr-Kanister Mr-Kanister force-pushed the 117-finding-symbols-from-oat branch from 9df796f to 7deabd2 Compare December 4, 2024 11:07
@Mr-Kanister Mr-Kanister marked this pull request as draft December 4, 2024 11:11
rust/backend/daemon/src/symbols.rs Outdated Show resolved Hide resolved
rust/backend/daemon/src/symbols.rs Outdated Show resolved Hide resolved
rust/backend/daemon/src/symbols.rs Outdated Show resolved Hide resolved
@Mr-Kanister Mr-Kanister force-pushed the 117-finding-symbols-from-oat branch from 4d52c19 to 3f7a856 Compare December 4, 2024 21:04
@Mr-Kanister Mr-Kanister requested a review from fhilgers December 5, 2024 02:15
@Mr-Kanister Mr-Kanister force-pushed the 117-finding-symbols-from-oat branch 2 times, most recently from cade3c3 to 9bf9c4a Compare December 5, 2024 13:54
@Mr-Kanister Mr-Kanister marked this pull request as ready for review December 5, 2024 14:40
luca-dot-sh
luca-dot-sh previously approved these changes Dec 5, 2024
Copy link
Contributor

@luca-dot-sh luca-dot-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Kotlin side, just have a few questions about the symbols flow

@Mr-Kanister Mr-Kanister force-pushed the 117-finding-symbols-from-oat branch 3 times, most recently from 278e26a to fdf22c4 Compare December 6, 2024 15:35
BenediktZinn and others added 14 commits December 6, 2024 16:36
Signed-off-by: Benedikt Zinn <[email protected]>
Co-authored-by: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
Co-authored-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Co-Authored-By: Benedikt Zinn <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
Co-Authored-By: Benedikt Zinn <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Co-Authored-By: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
View all new subcommands via `cargo xtask client -- help`. You will get
per-subcommand-help via `cargo xtask client -- <SUBCOMMAND> --help`.

In this regard deleted the daemon/bin/cli.rs as it was duplicated and
more complicated than client/bin/cli.rs

Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
@Mr-Kanister Mr-Kanister force-pushed the 117-finding-symbols-from-oat branch from fdf22c4 to a496c53 Compare December 6, 2024 15:38
@Mr-Kanister Mr-Kanister merged commit fc07ae5 into dev Dec 9, 2024
7 checks passed
@Mr-Kanister Mr-Kanister deleted the 117-finding-symbols-from-oat branch December 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants