generated from amosproj/amos202Xss0Y-projname
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding symbols from oat/dex files #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Kanister
force-pushed
the
117-finding-symbols-from-oat
branch
from
December 4, 2024 11:07
9df796f
to
7deabd2
Compare
fhilgers
previously requested changes
Dec 4, 2024
Mr-Kanister
force-pushed
the
117-finding-symbols-from-oat
branch
from
December 4, 2024 21:04
4d52c19
to
3f7a856
Compare
Mr-Kanister
force-pushed
the
117-finding-symbols-from-oat
branch
2 times, most recently
from
December 5, 2024 13:54
cade3c3
to
9bf9c4a
Compare
luca-dot-sh
previously approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from Kotlin side, just have a few questions about the symbols flow
frontend/client/src/real/java/de.amosproj3.ziofa.client/RustClient.kt
Outdated
Show resolved
Hide resolved
frontend/client/src/real/java/de.amosproj3.ziofa.client/RustClient.kt
Outdated
Show resolved
Hide resolved
Mr-Kanister
force-pushed
the
117-finding-symbols-from-oat
branch
3 times, most recently
from
December 6, 2024 15:35
278e26a
to
fdf22c4
Compare
Signed-off-by: Benedikt Zinn <[email protected]> Co-authored-by: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]> Co-authored-by: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Co-Authored-By: Benedikt Zinn <[email protected]> Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
Signed-off-by: Benedikt Zinn <[email protected]>
Co-Authored-By: Benedikt Zinn <[email protected]> Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Co-Authored-By: Mr-Kanister <[email protected]> Signed-off-by: Benedikt Zinn <[email protected]>
View all new subcommands via `cargo xtask client -- help`. You will get per-subcommand-help via `cargo xtask client -- <SUBCOMMAND> --help`. In this regard deleted the daemon/bin/cli.rs as it was duplicated and more complicated than client/bin/cli.rs Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
Mr-Kanister
force-pushed
the
117-finding-symbols-from-oat
branch
from
December 6, 2024 15:38
fdf22c4
to
a496c53
Compare
fhilgers
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now able to get a list of all .odex files related to a specified pid.
With a then selected .odex file it is further possible to get a list of all compiled (that is with offset != 0) symbols out of that .odex file. The method names get supplied together with the offsets.
With the desired method and offset filtered out of the list, it will then be possible to attach a uProbe onto the symbol.
As a sidequest the
daemon/bin/cli.rs
client got remove as it was unnecessary. The (better)client/bin/cli.rs
client got extended to support the mentioned changes and got an overall polish. There are now multiple subcommands which can be viewed viacargo xtask client -- help
. Each subcommand has it's own help page viacargo xtask client -- <SUBCOMMAND> --help
as well.The (not intended) sidequest should have been outsourced to a different issue, but well...
Closes #117