Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avable config and localtime settings in runCMD #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCubicleJockey
Copy link

  • Adding a way to save the configs, and edit the configs to Ampache on the fly
  • Sharing the localtime settings from the host to the Ampache image

@lachlan-00
Copy link
Member

Thank you. Will build at home and merge after testing.

I'm still trying to find out who owns the Ampache docker hub account so I can update the webhooks to restart automated builds

@TheCubicleJockey
Copy link
Author

Looks like the project owner has moved on from the project, I can't speak for them but they have this on the README "Notice: Only pull requests (PR) for bug fixes will be considered."

I wish they excepted feature pushing, I would like a better replacement for my main media server and Ampache looks like a nice base.

@lachlan-00
Copy link
Member

Don't worry, i'm getting there!
Ampache 4 isn't far away and there has been a lot of bugfixing and quality updates going on.

I'm an admin of this repo but not the main ampache repo so things move a bit slower there.

@lachlan-00
Copy link
Member

since the config is in one file would it be better to do it this way like localtime?

-v /path/to/savable/config/ampache.cfg.php:/var/www/config/ampache.cfg.php

@TheCubicleJockey
Copy link
Author

I believe that can work but on my machines this deletes the file inside the container. If the file is outside the contianer, it works fine.

At home and work, I have been using the folder when the file is inside the container. Note hosts machines are always linux based.

@lachlan-00
Copy link
Member

Cool, that's fine. Just asking. I'll test soon

@TheCubicleJockey
Copy link
Author

TheCubicleJockey commented Sep 26, 2019

OK i looked into this. It looks like it may not be an issue in windows but in linux/*inux systems the -v command is a Name Spaces trick. a single file from container can't be shared because the container cant write a file to the system (kind of but this is tricky), but it can if you -v a folder that folder can be written into be the container. There is so much more about name spaces that i have been exploring.

@KaeTuuN
Copy link

KaeTuuN commented Oct 12, 2023

@lachlan-00 I think this one is obsolete and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants