Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT-10914: Fix hosted zone filtering #606

Merged
merged 2 commits into from
Dec 1, 2023
Merged

AT-10914: Fix hosted zone filtering #606

merged 2 commits into from
Dec 1, 2023

Conversation

rddimon
Copy link
Collaborator

@rddimon rddimon commented Dec 1, 2023

https://amplify-education.atlassian.net/browse/AT-10914

Fixes #600

Description of Issue Fixed
Fixed hosted zone filtering

Changes proposed in this pull request:

  • Fixed hosted zone filtering
  • Updated tests

@rddimon rddimon self-assigned this Dec 1, 2023
@rddimon rddimon added the bug label Dec 1, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amplify-self-hosted-runners
Copy link

Check Name Conclusion Summary Output
SonarCloud Code Analysis success Quality Gate passed output
Mend Security Check neutral Security Report output
Mend License Check neutral License Report output
test (14.x) success test (14.x) output
test (16.x) success test (16.x) output
test (18.x) success test (18.x) output
test (20.x) success test (20.x) output
SonarCloud success No new alerts in code changed by this pull request output

@rddimon rddimon merged commit dba13b4 into main Dec 1, 2023
8 checks passed
@rddimon rddimon deleted the bugfix/AT-10914-hosted-zone-filtering branch December 1, 2023 15:45
@jormaechea jormaechea mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluhovyi mluhovyi mluhovyi approved these changes

@aoskotsky-amplify aoskotsky-amplify aoskotsky-amplify approved these changes

@kkozik-amplify kkozik-amplify Awaiting requested review from kkozik-amplify

Assignees

@rddimon rddimon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect hosted zone chosen when attempting to create a custom domain name
3 participants
@rddimon @aoskotsky-amplify @mluhovyi