[release-calendar] Calendar view date #821
Conversation
| } else { | ||
| this.setState({singleEvents: []}); | ||
| this.gotoDate(new Date()); |
There was a problem hiding this comment.
Curious, does Full Calendar have a "go to Today" button option? Going back to the current date when you remove filters might be unexpected, so I'm not sure we should do this. But having a "go to Today" button would help!
| } else { | ||
| this.setState({singleEvents: []}); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| gotoDate = (date: Date): void => { |
There was a problem hiding this comment.
Is there a reason why you use an anonymous function here and not a regular function syntax? (gotoDate(date: Date): void {)
Anonymous functions are more useful when you use them as, say, an argument to another function (e.g., arr.sort((firstEl, secondEl) => { ... }))
There was a problem hiding this comment.
No there wasn't any reason. I just wasn't aware one was the "regular", and I've gotten used to the anonymous way since I use functions as arguments more often. I'll switch this one to the regular function syntax!
|
|
This will navigate the calendar to a relevant date when a release is selected.
Undesirable behavior: Let's say a user went to select a release, but was viewing the calendar in a different month than one where the requested release had been promoted in. Then, when they select to view the release, the calendar could appear empty.
Fix: Change the calendar to display the month of the latest release promotion when a release is selected. Also, when a release is unselected, return the viewer to the current month.
Included:
referenceCalendar, in order to access theFullCalendarmethodgotoDate(), https://fullcalendar.io/docs/Calendar-gotoDate.gotoDate(date: Date)which uses thereferenceCalendarto change the calendar view dategotoDate()when theCalendarcomponentsingleReleasestate is changedhandleReleaseClick()inChannelTablethat I should have done long ago