Codec c short support edits #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a common practice to drop support for non-LTS Node versions, as it allows to reduce the maintenance burden. See more at: https://nodejs.org/en/about/releases/
The links to github pages were broken but I found I could get to working pages by changing github.com to github.io. It was then redirected to squaremobius.net. The changelog and tutes link pointed to master that has been rename to main.
Signed-off-by: Michael Bridgen <[email protected]>
Support for Node prior to v10 has been removed. It would be nice to check against older NodeJS versions, but it can't be required by CI. Signed-off-by: Michael Bridgen <[email protected]>
This is based on the Node.JS template, with an extra step to install RabbitMQ. Signed-off-by: Michael Bridgen <[email protected]>
The test workflow (rightfully) uses `npm ci`, which will balk if the
lockfile does not reflect version in package.json. This commit makes
sure they match, through
npm install
Signed-off-by: Michael Bridgen <[email protected]>
Co-authored-by: Alessandro Attene <[email protected]> Co-authored-by: Igor Savin <[email protected]>
|
Too many commits. Must have done something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to merge #620 but couldn't because the ordering of the code type tags had changed resulting in a duplicate entry for 'u'.