-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated namespace references and method adjustments for better compatibility #63
Open
Justany
wants to merge
3
commits into
amranidev:master
Choose a base branch
from
Justany:new-features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility Updated namespace references and method adjustments for better compatibility - Changed all instances where `Laracombee` was used to `Amranidev\Laracombee\Facades\LaracombeeFacade` across various commands in the src/console/command directory to align with proper namespace referencing. - Updated method implementations in `LaracombeeCommand` to reflect recent changes and enhance functionality. - Increased the default API timeout from 2000ms to 5000ms to improve reliability under slow network conditions and ensure smoother API interactions. These updates aim to enhance the package's maintainability and usability, particularly in environments with varied network speeds.
Hi @Justany, thanks for your contribution. I'm not sure how did you updated the composer.lock, it would be risky to merge since the Tests are failing during the install dependencies step, check code build. Thanks 🙏
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated namespace references and method adjustments for better compatibility
Laracombee
was used toAmranidev\Laracombee\Facades\LaracombeeFacade
across various commands in the src/console/command directory to align with proper namespace referencing.LaracombeeCommand
to reflect recent changes and enhance functionality.These updates aim to enhance the package's maintainability and usability, particularly in environments with varied network speeds.