Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated namespace references and method adjustments for better compatibility #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Justany
Copy link

@Justany Justany commented Aug 18, 2024

Updated namespace references and method adjustments for better compatibility

  • Changed all instances where Laracombee was used to Amranidev\Laracombee\Facades\LaracombeeFacade across various commands in the src/console/command directory to align with proper namespace referencing.
  • Updated method implementations in LaracombeeCommand to reflect recent changes and enhance functionality.
  • Increased the default API timeout from 2000ms to 5000ms to improve reliability under slow network conditions and ensure smoother API interactions.

These updates aim to enhance the package's maintainability and usability, particularly in environments with varied network speeds.

…ibility

Updated namespace references and method adjustments for better compatibility

- Changed all instances where `Laracombee` was used to `Amranidev\Laracombee\Facades\LaracombeeFacade` across various commands in the src/console/command directory to align with proper namespace referencing.
- Updated method implementations in `LaracombeeCommand` to reflect recent changes and enhance functionality.
- Increased the default API timeout from 2000ms to 5000ms to improve reliability under slow network conditions and ensure smoother API interactions.

These updates aim to enhance the package's maintainability and usability, particularly in environments with varied network speeds.
@amranidev
Copy link
Owner

amranidev commented Aug 25, 2024

Hi @Justany, thanks for your contribution.

I'm not sure how did you updated the composer.lock, it would be risky to merge since the Tests are failing during the install dependencies step, check code build.
Can you please remove the composer.lock change from the PR so I can re run the code build to see if it be passed through.

Thanks 🙏

Run composer install --prefer-dist --no-progress
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - symfony/css-selector is locked to version v7.1.1 and an update of this package was not requested.
    - symfony/css-selector v7.1.1 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 2
    - symfony/event-dispatcher is locked to version v7.1.1 and an update of this package was not requested.
    - symfony/event-dispatcher v7.1.1 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 3
    - symfony/stopwatch is locked to version v7.1.1 and an update of this package was not requested.
    - symfony/stopwatch v7.1.1 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem [4](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:5)
    - symfony/string is locked to version v7.1.3 and an update of this package was not requested.
    - symfony/string v7.1.3 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem [5](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:6)
    - symfony/string v7.1.3 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
    - symfony/console v[6](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:7).4.10 requires symfony/string ^5.4|^6.0|^7.0 -> satisfiable by symfony/string[v7.1.3].
    - symfony/console is locked to version v6.4.10 and an update of this package was not requested.

Error: Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - symfony/css-selector is locked to version v[7](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:8).1.1 and an update of this package was not requested.
    - symfony/css-selector v7.1.1 requires php >=[8](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:9).2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 2
    - symfony/event-dispatcher is locked to version v7.1.1 and an update of this package was not requested.
    - symfony/event-dispatcher v7.1.1 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 3
    - symfony/stopwatch is locked to version v7.1.1 and an update of this package was not requested.
    - symfony/stopwatch v7.1.1 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 4
    - symfony/string is locked to version v7.1.3 and an update of this package was not requested.
    - symfony/string v7.1.3 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
  Problem 5
    - symfony/string v7.1.3 requires php >=8.2 -> your php version (8.1.2) does not satisfy that requirement.
    - symfony/console v6.4.[10](https://github.com/amranidev/laracombee/actions/runs/10443924276/job/29223513540?pr=63#step:5:11) requires symfony/string ^5.4|^6.0|^7.0 -> satisfiable by symfony/string[v7.1.3].
    - symfony/console is locked to version v6.4.10 and an update of this package was not requested.

Error: Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants