Skip to content

Commit

Permalink
fix: encoding for URLs related to Critical updates
Browse files Browse the repository at this point in the history
When a Critical Update Name contained an ampersand symbol, the update
could not be processed.
  • Loading branch information
amtrack committed Oct 11, 2019
1 parent ba4469d commit d6d99d2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/plugins/company-settings/critical-updates/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import { BrowserforcePlugin } from '../../../plugin';

const PATHS = {
BASE: 'ruac/ruacPage.apexp',
REVIEW: '/ruac/CriticalUpdateDetail.apexp?name=',
ACTIVATE: '/ruac/CriticalUpdateActivate.apexp?name=',
DEACTIVATE: '/ruac/CriticalUpdateDeactivate.apexp?name='
REVIEW: 'ruac/CriticalUpdateDetail.apexp?name=',
ACTIVATE: 'ruac/CriticalUpdateActivate.apexp?name=',
DEACTIVATE: 'ruac/CriticalUpdateDeactivate.apexp?name='
};
const SELECTORS = {
TABLE_BODY: 'tbody[id$=":featuresTable:tb"]',
Expand Down Expand Up @@ -78,7 +78,7 @@ export default class CriticalUpdates extends BrowserforcePlugin {
for (const update of config) {
const url = `${
update.active ? PATHS.ACTIVATE : PATHS.DEACTIVATE
}${encodeURI(update.name)}`;
}${encodeURIComponent(update.name)}`;
const page = await this.browserforce.openPage(url);
const buttonSelector = update.active
? SELECTORS.FORM_ACTIVATE_BUTTON
Expand Down

0 comments on commit d6d99d2

Please sign in to comment.