Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the new setup domain for lightning pages if available #650

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

amtrack
Copy link
Owner

@amtrack amtrack commented Dec 5, 2024

No description provided.

Opening a `/lightning/` setup page on the instance domain caused
multiple server- and client-side redirects to the new setup domain.

This caused errors like:

> failed: Protocol error (DOM.describeNode): Cannot find context with specified id

Now all lightning pages should open using the new setup domain if available
and use the instance URL otherwise.

Example: https://[MyDomainName].my.salesforce-setup.com
@amtrack amtrack changed the title fix: determine setup url on login to avoid redirects per page load feat: use the new setup domain for lightning pages if available Dec 6, 2024
@amtrack amtrack marked this pull request as ready for review December 6, 2024 10:25
@amtrack amtrack merged commit 9bcd8e3 into main Dec 6, 2024
1 check passed
@amtrack amtrack deleted the fix/use-setup-url branch December 6, 2024 10:33
Copy link

github-actions bot commented Dec 6, 2024

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant