Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make whitespace match PSR/2 standard (3.2.0 update) #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ejegg
Copy link

@ejegg ejegg commented Dec 15, 2017

This is the recommended standard for PHP libraries

Also inserts missing braces around one-line conditionals and standardizes case of booleans.

@ejegg
Copy link
Author

ejegg commented Dec 15, 2017

@bjguillot , to review this you might want to use the '-w' switch to 'git diff' or 'git log'

That switch will ignore all the changes where whitespace is just inserted or deleted within a single line, and show all the place where braces have been moved to different lines, etc.

This was referenced Dec 15, 2017
@ejegg
Copy link
Author

ejegg commented Dec 15, 2017

Fixes #34

@bjguillot
Copy link
Contributor

Thanks for the suggestion on the '-w' switch.

@ejegg ejegg force-pushed the 3.2.0-ws branch 3 times, most recently from 2a9fe1b to 2bd2018 Compare January 11, 2018 23:23
To make future diffs cleaner.
Also inserts explicit braces around oneline if statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants