Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLinear mmap unittest #274

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

weiliw-amz
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Add unit test for memory-mapped XLinear model compile, load & predict.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@weiliw-amz weiliw-amz self-assigned this Jan 6, 2024
@OctoberChang
Copy link
Contributor

@weiliw-amz , can we also add some test cases on the get attribute functions, to increase the coverage of pytest?

For example,

assert py_model.depth == mmap_model.depth
assert py_model.nr_features == mmap_model.nr_features
assert py_model.nr_labels == mmap_model.nr_labels
assert py_model.nr_codes == mmap_model.nr_codes

@weiliw-amz weiliw-amz force-pushed the xlinear-mmap-unittest branch from 6f4144e to 8165216 Compare January 6, 2024 08:39
@weiliw-amz
Copy link
Contributor Author

@weiliw-amz , can we also add some test cases on the get attribute functions, to increase the coverage of pytest?

For example,

assert py_model.depth == mmap_model.depth
assert py_model.nr_features == mmap_model.nr_features
assert py_model.nr_labels == mmap_model.nr_labels
assert py_model.nr_codes == mmap_model.nr_codes

Sounds good, added.

@OctoberChang OctoberChang merged commit 22f01be into amzn:mainline Jan 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants