Skip to content

Commit

Permalink
feat: removed p7zip dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
krypt0nn committed Aug 3, 2024
1 parent 57dde86 commit a92f359
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 51 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Removed

- Removed `p7zip` dependency

## [1.7.0] - 02.08.2024

### Added
Expand Down
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ glib-build-tools = "0.20"

[dependencies.anime-launcher-sdk]
git = "https://github.com/an-anime-team/anime-launcher-sdk"
tag = "1.17.2"
tag = "1.17.3"
features = ["all", "star-rail", "star-rail-patch"]

# path = "../anime-launcher-sdk" # ! for dev purposes only
Expand Down
26 changes: 1 addition & 25 deletions src/ui/about.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,34 +100,10 @@ impl SimpleComponent for AboutDialog {

set_release_notes_version: &APP_VERSION,
set_release_notes: &[
"<p>Added</p>",

"<ul>",
"<li>Added \"Indonesia\" wine language option</li>",
"<li>Added writing of the game's output to the \"game.log\" file in the launcher's folder</li>",
"<li>Respect root \".version\" file for game version parsing</li>",
"<li>Added 2.4.0 voiceovers sizes</li>",
"</ul>",

"<p>Fixed</p>",

"<ul>",
"<li>Fixed \"dwebp\" package name for fedora during initial setup</li>",
"<li>Fixed Discord RPC updates</li>",
"</ul>",

"<p>Changed</p>",

"<ul>",
"<li>Changed background images processing logic</li>",
"<li>Prioritize parsed game version over the API response</li>",
"</ul>",

"<p>Removed</p>",

"<ul>",
"<li>Removed \"xdelta3\" dependency</li>",
"<li>Removed migrate installation feature</li>",
"<li>Removed \"p7zip\" dependency</li>",
"</ul>"
].join("\n"),

Expand Down
22 changes: 3 additions & 19 deletions src/ui/first_run/dependencies.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl SimpleAsyncComponent for DependenciesApp {
},

gtk::Entry {
set_text: "sudo pacman -Syu git p7zip libwebp",
set_text: "sudo pacman -Syu git libwebp",
set_editable: false
}
},
Expand All @@ -85,7 +85,7 @@ impl SimpleAsyncComponent for DependenciesApp {
},

gtk::Entry {
set_text: "sudo apt install git p7zip-full webp",
set_text: "sudo apt install git webp",
set_editable: false
}
},
Expand All @@ -102,7 +102,7 @@ impl SimpleAsyncComponent for DependenciesApp {
},

gtk::Entry {
set_text: "sudo dnf install git p7zip libwebp-tools",
set_text: "sudo dnf install git libwebp-tools",
set_editable: false
}
},
Expand All @@ -119,10 +119,6 @@ impl SimpleAsyncComponent for DependenciesApp {
set_title: "git"
},

adw::ActionRow {
set_title: "p7zip"
},

adw::ActionRow {
set_title: "libwebp"
}
Expand Down Expand Up @@ -206,18 +202,6 @@ impl SimpleAsyncComponent for DependenciesApp {
}
}

// 7z sometimes has different binaries
if !is_available("7z") && !is_available("7za") {
sender.output(Self::Output::Toast {
title: tr!("package-not-available", {
"package" = "7z"
}),
description: None
});

return;
}

sender.output(Self::Output::ScrollToDefaultPaths);
}

Expand Down
3 changes: 1 addition & 2 deletions src/ui/first_run/tos_warning.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ impl SimpleAsyncComponent for TosWarningApp {
"continue" => {
let installed =
is_available("git") &&
is_available("dwebp") &&
(is_available("7z") || is_available("7za"));
is_available("dwebp");

if installed {
sender.output(Self::Output::ScrollToDefaultPaths);
Expand Down

0 comments on commit a92f359

Please sign in to comment.