style(Other): Update conditional compilation directives for CONFIG_SOC_* definitions in Zephyr wrapper
#1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsm
force-pushed
the
fix_zephyr_wrap_if_statements
branch
2 times, most recently
from
e3ff00f to
a25361c
Compare
The 'if defined(FOO) || BAR' lines are not clear $ sed 's, (CONFIG_SOC, defined(CONFIG_SOC,g' -i $(git grep --name-only if.defined\(.*\|\|.\() $ sed 's,||\s*\\$,\|\| \\,g' -i $(git grep --name-only '||.*\\$') Signed-off-by: Matthew McClintock <[email protected]>
mattsm
force-pushed
the
fix_zephyr_wrap_if_statements
branch
from
a25361c to
0737cfe
Compare
mattsm
changed the title
mattsm
changed the title
sihyung-maxim
changed the title
CONFIG_SOC_* definitions in Zephyr wrapper
|
The pull request template contains guidelines on how to title PRs. The guidelines also appear in the description when opening a PR. |
ozersa
requested changes
Dec 4, 2024
MaureenHelm
approved these changes
Dec 4, 2024
sihyung-maxim
changed the title
CONFIG_SOC_* definitions in Zephyr wrapperCONFIG_SOC_* definitions in Zephyr wrapper
sihyung-maxim
approved these changes
Dec 4, 2024
ozersa
approved these changes
Dec 5, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Dec 6, 2024
EricB-ADI
pushed a commit
that referenced
this pull request
Jan 6, 2025
…OC_*` definitions in Zephyr wrapper (#1278) Signed-off-by: Matthew McClintock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'if defined(FOO) || BAR' lines are not clear
$ sed 's, (CONFIG_SOC, defined(CONFIG_SOC,g' -i $(git grep --name-only if.defined(.||.() $ sed 's,||\s\$,|| \,g' -i $(git grep --name-only '||.*\$')
Description
Not much to add other than the subject of the single git commit above.
Checklist Before Requesting Review