Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(Other): Add Apache License 2.0 #780

Merged
merged 53 commits into from
Nov 14, 2023
Merged

style(Other): Add Apache License 2.0 #780

merged 53 commits into from
Nov 14, 2023

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Oct 24, 2023 •
edited
Loading

Description

This PR adds the Apache 2.0 License to the SDK. This only applies to files with the permissive, open-source version of the Maxim Integrated Copyright notice.

THe ME13 and ME55 files are ignored in this PR as they will be updated in a separate PR.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@sihyung-maxim
Copy link
Contributor Author

Jacob and I did a spot check on all file types (.cpp, .c, .h, .s, .S, .ld, .mk, Makefiles, .py, and .txt).

@github-actions github-actions bot added MAX32520 Related to the MAX32520 (ES17) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) BLE Related to Bluetooth MAX32662 Related to the MAX32662 (ME12) Register Change This issue or pull request involves a change to the MSDK registers. labels Oct 24, 2023
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@Jake-Carter
Copy link
Contributor

Looks like we need to blacklist SecureROM_BL_Host/test_images for the format checker or // clang-format off / //clang-format on the contents of the blinkled file

@sihyung-maxim sihyung-maxim added the WIP work in progress label Oct 25, 2023
@github-actions github-actions bot added Register Change This issue or pull request involves a change to the MSDK registers. and removed MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) labels Nov 7, 2023
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim sihyung-maxim removed the WIP work in progress label Nov 7, 2023
@sihyung-maxim
Copy link
Contributor Author

sihyung-maxim commented Nov 7, 2023 •
edited
Loading

The labeler is getting confused because that GitHub action only goes through the first 3000 files of a PR. The rest of the files are ignored. (This is due to GitHub only allowing you to view the first 3000 files in a PR review.)

lorne-maxim
lorne-maxim approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@lorne-maxim lorne-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I do see a *.Tariq file that probably needs to be deleted.

@sihyung-maxim sihyung-maxim merged commit 940dbfb into main Nov 14, 2023
8 checks passed
@sihyung-maxim sihyung-maxim deleted the update/apache_license branch November 14, 2023 21:57
@Jake-Carter Jake-Carter mentioned this pull request Nov 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorne-maxim lorne-maxim lorne-maxim approved these changes

@Jake-Carter Jake-Carter Jake-Carter approved these changes

Assignees
No one assigned
Labels
BLE Related to Bluetooth MAX32520 Related to the MAX32520 (ES17) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32662 Related to the MAX32662 (ME12) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) Register Change This issue or pull request involves a change to the MSDK registers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sihyung-maxim @Jake-Carter @lorne-maxim