Example of getting bytes instead of saving directly to file for speech #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandhall
commented
May 29, 2024
| @@ -159,7 +159,7 @@ packages: | |||
| path: ".." | |||
| relative: true | |||
| source: path | |||
| version: "4.1.4" | |||
| version: "5.1.0" | |||
There was a problem hiding this comment.
this was automatic, please revert if incorrect
dylandhall
commented
May 29, 2024
| @@ -13,6 +14,14 @@ abstract class CreateInterface { | |||
| Directory? outputDirectory, | |||
| }); | |||
|
|
|||
| Future<Uint8List> createSpeechBytes({ | |||
There was a problem hiding this comment.
couldn't create an overload with the same param names, rename if unsuitable.
dylandhall
commented
May 29, 2024
| return response.bodyBytes; | ||
| } | ||
|
|
||
| static Future<http.Response> postAndGetResponse({ |
There was a problem hiding this comment.
separated the basics of getting the response with bytes data so we still have the error handling/logging
dylandhall
commented
May 29, 2024
| }) async { | ||
|
|
||
| var response = await postAndGetResponse(to: to, body: body, client: client); | ||
| return response.bodyBytes; |
There was a problem hiding this comment.
in this case just get the bytes, should mean we can play with AudioPlayer BytesSource data source on platforms which don't support file operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the speech API to allow getting the bytes directly to play.
This will allow platforms like web which cannot write files to play the audio, and will allow other platforms to play the audio without adding file system permissions to write the temporary files.
tests as working with code: