chore: shrink listing file to speed download times #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listing file is large enough and frequently enough downloaded that we expect better performance with a smaller listing database file. Signed-off-by: Will Murphy <[email protected]>
kzantow
reviewed
Aug 2, 2024
| @@ -17,8 +17,8 @@ | |||
| from collections.abc import Generator | |||
|
|
|||
| DB_SUFFIXES = {".tar.gz", ".tar.zst"} | |||
| MAX_DB_AGE = 120 # ~4 months in days | |||
| MINIMUM_DB_COUNT = MAX_DB_AGE # number of db entries per schema | |||
| MAX_DB_AGE = 7 # old db listings are making the file large and slowing download times | |||
There was a problem hiding this comment.
My vote is to make this 2, which would support what I think are the main use cases:
- get the latest
- see what's changed in the latest
There was a problem hiding this comment.
Sounds good. I'll do that and also figure out why unit tests are failing.
There was a problem hiding this comment.
I went with 3 because it prevents having to rewrite a test fixture. Do you think it's important to push for 2 @kzantow?
Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listing file is large enough and frequently enough downloaded that we expect better performance with a smaller listing database file.
See anchore/grype#1731