Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dev debug build using delve #64

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

bradleyjones
Copy link
Member

Skaffold debug doesn't currently support go 1.21 so this is a workaround
until skaffold is updated.

Signed-off-by: Bradley Jones [email protected]

Copy link

@asomya asomya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, LGTM otherwise

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Skaffold debug doesn't currently support go 1.21 so this is a workaround
until skaffold is updated.

Signed-off-by: Bradley Jones <[email protected]>
Makefile Outdated Show resolved Hide resolved
Copy link

@juanjsebgarcia juanjsebgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment but non-blocking as it maybe what you intended

Dockerfile-dev Outdated Show resolved Hide resolved
@bradleyjones bradleyjones merged commit 8101eb2 into main Nov 3, 2023
4 checks passed
@bradleyjones bradleyjones deleted the delve-debug-build branch November 3, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants