#141392693 New dashboard tab for failed jobs. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonerdo
suggested changes
Apr 13, 2017
hc/front/views.py
Outdated
| @login_required | ||
| def reports(request): | ||
| checks = Check.objects.filter(user=request.team.user).order_by("created") | ||
| failed_checks = [] |
There was a problem hiding this comment.
Use list comprehension:
failed_checks = [check for check in checks if check.get_status() == "down" and check.n_pings]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new dashboard tab for failed jobs
Description of Task to be completed?
Apart from the email notifications, the user also has a separate dashboard view of their failed jobs.
How should this be manually tested?
What are the relevant pivotal tracker stories?
#141392693
Screenshots (if appropriate)