-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166840975 user can rate artilce #13
Open
Alpha1202
wants to merge
1
commit into
staging
Choose a base branch
from
ft-rate-articles-166840975
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
August 29, 2019 15:58
c488b6c
to
937fa67
Compare
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
August 29, 2019 16:38
937fa67
to
3dbf05d
Compare
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
August 29, 2019 16:42
3dbf05d
to
4b392b7
Compare
codeBlock-1984
approved these changes
Aug 29, 2019
phembarl
approved these changes
Aug 29, 2019
czarjulius
approved these changes
Aug 30, 2019
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
September 2, 2019 10:04
4b392b7
to
ae7a9dc
Compare
Code Climate has analyzed commit ae7a9dc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 87.5% (70% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (-0.5% change). View more on Code Climate. |
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
September 3, 2019 08:08
ae7a9dc
to
faf37c6
Compare
add a temporary login form add a temporary get all articles page add read one article page add a dropdown button add the star rating modal add the an on-success notification [Starts #166840975]
Alpha1202
force-pushed
the
ft-rate-articles-166840975
branch
from
September 3, 2019 10:44
faf37c6
to
d7896fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
log in to the app to get a token
Click on any article to read
Click on the dropdown button to view the rate article link
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: