Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

166840973-ft-user-can-view-and-edit-profile #31

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

166840973-ft-user-can-view-and-edit-profile #31

wants to merge 1 commit into from

Conversation

Alpha1202
Copy link
Contributor

What does this PR do?

  • user-can-view-and-edit-profile

Description of Task to be completed?

  • create a user profile page
  • fetch get user profile API
  • fetch get user followers API
  • fetch get user followee API
  • fetch get users authored articles API
  • fetch update user profile API

How should this be manually tested?

  • After cloning the repo
  • run npm install
  • run npm run dev to start the development
  • navigate to localhost://3000/login to login and view your dashboard

Any background context you want to provide?

  • user can view and edit profile

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

  • N/A

Questions:

  • N/A

@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 22, 2019 07:36 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from d7db133 to aac0f3a Compare August 23, 2019 07:45
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 23, 2019 07:45 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from aac0f3a to 32509ca Compare August 26, 2019 08:58
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 26, 2019 08:58 Inactive
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 27, 2019 08:09 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 19d5dea to 1b31b93 Compare August 28, 2019 11:29
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 28, 2019 11:29 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 1b31b93 to 9e610b2 Compare August 28, 2019 14:11
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 28, 2019 14:11 Inactive
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 28, 2019 14:40 Inactive
codeclimate[bot]
codeclimate bot reviewed Aug 28, 2019
View reviewed changes
src/reducers/userReducer.js
articles: [],
};

const reducer = (state = initialState, action) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function reducer has 84 lines of code (exceeds 80 allowed). Consider refactoring.

@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 6936b21 to 9446474 Compare August 28, 2019 14:44
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 28, 2019 14:45 Inactive
codeBlock-1984
codeBlock-1984 approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@codeBlock-1984 codeBlock-1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Alpha1202.

@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 9446474 to 5de8619 Compare August 30, 2019 16:54
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 August 30, 2019 16:54 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 5de8619 to c3a43ad Compare September 2, 2019 07:38
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 September 2, 2019 07:38 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from c3a43ad to 477cf24 Compare September 2, 2019 08:11
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 September 2, 2019 08:11 Inactive
codeclimate[bot]
codeclimate bot reviewed Sep 2, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17568 lines exceeds the maximum allowed for the inline comments feature.

@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 477cf24 to 2f82182 Compare September 2, 2019 08:14
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 September 2, 2019 08:14 Inactive
codeclimate[bot]
codeclimate bot reviewed Sep 2, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 17568 lines exceeds the maximum allowed for the inline comments feature.

@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 2f82182 to f52b9eb Compare September 2, 2019 09:07
@Cavdy Cavdy had a problem deploying to ah-nyati-frontend-pr-31 September 2, 2019 09:08 Failure
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from f52b9eb to b363d03 Compare September 2, 2019 09:10
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 September 2, 2019 09:11 Inactive
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from b363d03 to 91a0c47 Compare September 3, 2019 07:54
@Cavdy Cavdy temporarily deployed to ah-nyati-frontend-pr-31 September 3, 2019 07:54 Inactive
@Alpha1202
ft-user-can-view-and-edit-own-profile
3b30826 
create view authenticated user profile
fetch user profile api
fetch user followers api
fetch user followee api
fetch user article api
fetch user published article api
fetch user draft article api
fetch user update profile api
create edit profile form
[Finishes #166840973]
@Alpha1202 Alpha1202 force-pushed the ft-user-can-view-and-edit-own-profile-166840973 branch from 91a0c47 to 3b30826 Compare September 3, 2019 10:32
@codeclimate
Copy link

codeclimate bot commented Sep 3, 2019

Code Climate has analyzed commit 3b30826 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 99.4% (70% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.9% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@Cavdy Cavdy Cavdy approved these changes

@codeBlock-1984 codeBlock-1984 codeBlock-1984 approved these changes

@czarjulius czarjulius czarjulius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alpha1202 @czarjulius @codeBlock-1984 @Cavdy