Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint for setting user email address (STAM-5) #177

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

jopesy
Copy link
Collaborator

@jopesy jopesy commented Jun 12, 2024

Add a REST API endpoint for setting the user's email address if it's empty.

This is the case when an authentication provider such as PIKI library card or Suomi.fi is used to log in and the user doesn't have an email address available there. Allowing the user to set their email address in Respa ensures that the email address is saved to the User's detailsand having to include the reserver_email field in reservation forms is not required.

This also fixed the issue with the email address not being included in the access control request to Securitas Flow if it's missing from the user's details.

Refs STAM-5

jopesy added 3 commits June 13, 2024 10:40
Getting requirements to build wheel did not run
succesfully due to and error in importing from
setuptools.
Add a REST API endpoint for setting the user's email
address if it's empty.

Refs STAM-5
@jopesy jopesy force-pushed the stam-5-user-email-form branch from d3addb8 to 01df826 Compare June 13, 2024 07:41
@jopesy jopesy changed the title WIP: API endpoint for setting user email address (STAM-5) API endpoint for setting user email address (STAM-5) Jun 13, 2024
@jopesy jopesy requested review from samimedallal and rbreve June 13, 2024 12:16
Copy link

@samimedallal samimedallal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jopesy jopesy merged commit 77775aa into tre-varaamo-qa Jun 13, 2024
1 check passed
@jopesy jopesy deleted the stam-5-user-email-form branch June 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants