Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local docker setup #184

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

jorilindell
Copy link
Collaborator

@jorilindell jorilindell commented Oct 1, 2024

Description

At the moment local development environment is not working with Docker compose. There are 2 reasons for that

  • wait-for-it.sh is not found
  • Postgres extensions are not installed in docker entrypoint because postgres user is not found

This PR fixes those issues by implementing following changes:

  • use curl to get wait-for-it.sh script and store it as /usr/local/bin/wait-for-it.sh
  • Add missing DATABASE_HOST and DATABASE_POST environment variables to docker-compose.yml
  • Use correct database user to install extensions

Get wait-for-it.sh by using curl instead of having local file
Add missing environment variables to docker-compose.yml file to make wait-for-it.sh to work
Use correct database user when installing extensions in docker entrypoint
Copy link

@samimedallal samimedallal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jorilindell jorilindell merged commit 692873e into tre-varaamo-qa Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants