Adds support to more column types #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traduzindo p ptbr; capitalizando tdas as palavras do titulo da issue; add opção de criterios extras
andre-filho
requested changes
Oct 10, 2020
| @@ -38,7 +38,7 @@ def format_description(string): | |||
| """ | |||
| Adds the header and a final new line to the issue description string. | |||
| """ | |||
| return str('**Issue description:**\n---\n\n' + string + '\n'*2) | |||
There was a problem hiding this comment.
Keep it in english for now. Translations will be added later. Btw there is a branch named desenho-br I think, that writes the issue titles and stuff in pt-br and is deployed on ezissue-br lib
| @@ -47,12 +47,12 @@ def add_prefix_to_title(title, number, prefix, subid, numerate): | |||
| """ | |||
| subid = subid.upper() | |||
| prefix = prefix.upper() | |||
| title = title.capitalize() | |||
| title = ' '.join([t.capitalize() for t in title.split(' ')]) | |||
There was a problem hiding this comment.
Split this into a function plz
| @@ -82,11 +82,20 @@ def format_acc_criteria(string): | |||
| Formats the string adding the acceptance criteria header and adds a final | |||
| new line. | |||
| """ | |||
| checkboxes = add_md_checkbox(string) | |||
| acc_criteria_title = "**Acceptance criteria:**\n---\n\n" | |||
| checkboxes = add_md_checkbox(string) if string != 'Não há critérios.\n' else string | |||
There was a problem hiding this comment.
Shouldn't this logic be inside the add_md_checkbox function? It is simple, yes, but inside the function would be better organized
| Formats the string adding the acceptance criteria header and adds a final | ||
| new line. | ||
| """ | ||
| checkboxes = add_md_checkbox(string) if string != 'Não há critérios.\n' else string |
| @@ -16,15 +15,15 @@ | |||
| GITLAB_BASE_URL = "https://gitlab.com/api/v4" | |||
|
|
|||
|
|
|||
| def create_issue_json(configuration_row, values_row, repo_host): | |||
| def create_issue_json(configuration_row, values_row, repo_host, blk): | |||
There was a problem hiding this comment.
What is blk? Use significant variable names
| @@ -182,11 +187,15 @@ def main(filename, repo_host, prefix, subid, numerate, debug): | |||
| row[0] = add_prefix_to_title( | |||
| row[0], idx+1, prefix, subid, numerate) | |||
|
|
|||
| rows = make_md_formatting(columns, rows) | |||
| columns = [x.strip() for x in columns] | |||
There was a problem hiding this comment.
Significant variable names, plz
|
|
||
| for row in rows: | ||
| response, issue = make_api_call( | ||
| create_issue_json(columns, row, repo_host), | ||
| create_issue_json(columns, row, repo_host, blacklist), |
There was a problem hiding this comment.
If blacklist is being used on various places, should be extracted to constant
andre-filho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.