Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added changes for fedora checks #18128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

404ram
Copy link

@404ram 404ram commented Sep 10, 2019

New fedora 30 packages for python-pip and python-devel renamed to python2-* and command for pip renamed to pip

@andresriancho
Copy link
Owner

Thanks for the PR! The changes look good, but they are not backward-compatible. In other words, if I merge your change the dependency check for the old fedora distributions will fail.

Please take a look at how this is handled for Ubuntu (ubuntu*.py files in this directory) and submit new changes that properly handle both old and new Fedora versions.

@404ram
Copy link
Author

404ram commented Sep 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants