Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy and format Github Actions. #37

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Add clippy and format Github Actions. #37

merged 4 commits into from
Jun 23, 2024

Conversation

andriyDev
Copy link
Owner

Now pull requests will automatically determine if they satisfy clippy and rustfmt! I also fixed up all the clippy warnings so we're all green.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.2%. Comparing base (c8201e8) to head (900b2e7).

Additional details and impacted files
Files Coverage Δ
src/astar.rs 93.9% <100.0%> (ø)
src/avoidance.rs 95.7% <100.0%> (+<0.1%) ⬆️
src/nav_data.rs 99.3% <100.0%> (-0.1%) ⬇️
src/path.rs 91.6% <100.0%> (-0.1%) ⬇️
src/pathfinding.rs 100.0% <100.0%> (ø)
src/lib.rs 91.3% <57.1%> (-1.1%) ⬇️

The Ord implementation is just unwrapping the PartialOrd implementation, so this is essentially fine. Comparing floats is already not okay, but we need this to be Ord, so the unwrap is the cost.
@andriyDev andriyDev merged commit 1540180 into main Jun 23, 2024
6 checks passed
@andriyDev andriyDev deleted the clippy branch June 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants