Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SamplePlugin to compile and target API 35 #215

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

calren
Copy link
Contributor

@calren calren commented Nov 18, 2024

This matches the behavior defined in the overall app's build: https://github.com/android/platform-samples/blob/main/app/build.gradle.kts#L33 and fixes the build failure in this PR: #209 since media3-1.5 requires API 35

@lethargicpanda lethargicpanda self-assigned this Nov 18, 2024
Copy link

@lethargicpanda lethargicpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calren calren merged commit 06d584d into main Nov 18, 2024
2 checks passed
@calren calren deleted the caren/update_sample_plugin branch November 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants