Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor audio sample for comms devices only #81

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

marcelpinto
Copy link
Contributor

Simplified the audio sample and make it clear
that it's only for communication devices.

The sample now uses compose style approach
and isolates the specifics between:

  • AudioLoopSource
  • AudioDeviceState

Change-Id: I3cc51d068b5b8de93bcc6553b61552de4dfd91d3

Simplified the audio sample and make it clear
that it's only for communication devices.

The sample now uses compose style approach
and isolates the specifics between:
- AudioLoopSource
- AudioDeviceState

Change-Id: I3cc51d068b5b8de93bcc6553b61552de4dfd91d3
Change-Id: Ie92689ccb3c1075b77733584a706cae8606ae0df
Copy link
Contributor

@lukehopkinsdev lukehopkinsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner implementation for the audio manager

@lukehopkinsdev lukehopkinsdev merged commit 53247c1 into main Aug 14, 2023
@yrezgui yrezgui deleted the audio-comms branch December 7, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants