[Predictive Back] Add a new Predictive Back Samples folder. #94
Conversation
Set up recycler view to house interactive cards that will eventually show multiple samples. The recycler view does not currently have interactive samples. For now it describes how to view back-to-home and cross-activity animations.
|
|
||
| package com.example.platform.ui.predictiveback | ||
|
|
||
| class PBAnimation(val title: String, val description: String) |
There was a problem hiding this comment.
make it data class for just class holders
|
|
||
| class PBAnimation(val title: String, val description: String) | ||
|
|
||
| val pbAnimations = mutableListOf<PBAnimation>().apply { |
There was a problem hiding this comment.
it's better to use the constructor directly
mutableListOf(PBAnimation(...), PBAnimation(..), ...)
And if this list is not modified then defnie the variable type to be the immutable version List
|
|
||
| import androidx.lifecycle.ViewModel | ||
|
|
||
| class PBViewModel: ViewModel() { |
There was a problem hiding this comment.
Just for this I would skip the VM. Just use the variable directly. It's simple and clear
| name="Predictive Back Sample", | ||
| description="Shows Predictive Back animations." | ||
| ) | ||
| class PBHostingActivity : AppCompatActivity() { |
There was a problem hiding this comment.
Is the activity needed to demostrate the sample? If not maybe you could just use the fragment directly. This way you can skip the theme and all the boilerplate that comes with activity.
There was a problem hiding this comment.
Yes, the activity is needed. From the sample page folks can swipe back to see the cross-activity animation. I'm also hoping to add a custom cross-activity animation.
|
Compose side of things tbd |
Set up recycler view to house interactive cards that will eventually show multiple samples. The recycler view does not currently have interactive samples. For now it describes how to view back-to-home and cross-activity animations.
https://photos.app.goo.gl/QGL7DrBtMbGVqTLk7