Remove onTerminate in TilesApplication #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 8, 2022 13:45
- it's not called on prod devices - the app container will be GC'd anyway because the app is being destroyed
ataulm
commented
Jun 8, 2022
| /** | ||
| * Provides a [TimelineBuilders.Timeline] which has only one entry. | ||
| */ | ||
| internal fun singleEntryTimeline(rootLayout: LayoutElement): TimelineBuilders.Timeline { |
There was a problem hiding this comment.
potential candidate for horologist-tiles?
There was a problem hiding this comment.
I'm not sure we want informal Kotlin DSLs sprouting up
There was a problem hiding this comment.
& Do you mean in samples or Horologist?
There was a problem hiding this comment.
my mistake - I had the {} in MessagesRenderer but forgot to update that one bit!
added 2 commits
June 8, 2022 14:06
yschimke
approved these changes
Jun 8, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
singleEntryTimelineto reduce boilerplate. Added new issue Create Tile showcasing multiple timeline entries #402 because we don't demo multiple entry timelines