feat: add UpdateIssueWithOptions #658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make clear what it does Signed-off-by: rtweed <[email protected]>
RichardoC
changed the title
RichardoC
changed the title
|
I'd love a patch release to be made including this, as it means I can send thousands fewer emails a day from automation that noone wants to read |
RichardoC
commented
Feb 8, 2024
| testMux.HandleFunc("/rest/api/2/issue/PROJ-9001", func(w http.ResponseWriter, r *http.Request) { | ||
| testMethod(t, r, http.MethodPut) | ||
| testRequestURL(t, r, "/rest/api/2/issue/PROJ-9001") | ||
| testRequestParams(t, r, map[string]string{"notifyUsers": "false"}) |
There was a problem hiding this comment.
This test fails without the omitEmpty changes
Signed-off-by: rtweed <[email protected]>
RichardoC
force-pushed
the
UpdateIssueWithOptions
branch
from
34ca626
to
49194ca
Compare
|
Credit to @chrisnovakovic for finding this fix in thought-machine@3870a80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add testing for addOptions to make clear what it does
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: