Merge pull request #17 from AngelList/error-messages

More informative error messages for generic errors

lib/protip/error.rb

@@ -8,6 +8,12 @@ class Error < RuntimeError
     def initialize(request, response)
       @request = request
       @response = response
+
+      msg = <<-MSG
+Received HTTP #{response.code} from #{request.uri}. Response:
+#{response.body}
+      MSG
+      super(msg)
     end
 
     def inspect

protip.gemspec

@@ -1,7 +1,7 @@
 # encoding: utf-8
 Gem::Specification.new do |spec|
   spec.name          = 'protip'
-  spec.version       = '0.16.0'
+  spec.version       = '0.16.1'
   spec.summary       = 'ActiveModel resources backed by protocol buffers'
   spec.licenses      = ['MIT']
   spec.homepage      = 'https://github.com/AngelList/protip'

test/unit/protip/resource_test.rb

@@ -667,7 +667,13 @@ def self.it_converts_query_parameters
           # Set up an errors instance variable that we can set actual messages on
           @errors = Protip::Messages::Errors.new
 
-          exception = Protip::UnprocessableEntityError.new mock, mock
+          request = mock
+          request.stubs(:uri).returns('http://some.uri')
+
+          response = mock
+          response.stubs(code: 500, body: @errors.to_proto)
+
+          exception = Protip::UnprocessableEntityError.new request, response
           exception.stubs(:errors).returns @errors
           client.stubs(:request).raises(exception)