-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, polish stuff, make FileCallback.onCompleted receive newly created FileCallback.Result and more #144
Conversation
…move ExampleUnitTest & fix some gradle deprecation issues
…ntentSender) -> Unit)? = null)
Damn, I just now saw #142 😅 |
Hi @w2sv , thanks for raising this PR. I've reviewed your PR and you've done so much to improve the library quality. Unfortunately, I've planned to release v2.0.0 long time ago, and tested it multiple times to ensure its stability. So, I'll merge my PR first, then you can rebase your branch to the latest commits. I'll review your PR again once you've resolved the git conflicts. Thanks in advance. |
Yes, sounds absolutely perfect, I'll do that. Great PR btw, the migration to flows is awesome! |
Closing as I created an entirely now PR #145 |
I did lots of different things for which I really should have created separate PRs, sorry for that. To break it down:
kotlin
src dirs and moved thesample
java files to ajava
src dirand made it the result type argument of the
FileCallback
class, to make users unambiguously aware of theonCompleted
result typedata class Report(val progress: Float, val bytesMoved: Long, val writeSpeed: Int)
DEPRECATED
suppressionsto provide a common interface, as well as a higher degree of class cohesion
and made all callbacks holding a CoroutineScope inherit from it. In that wake, I replaced the I believe 103 invocations of
callback.uiScope.postToUi
withcallback.postToUiScope
compileSdkVersion
ofstorage
to 34 and removed the redundanttargetSdkVersion
, which has no effect on library modulesAs I said, quite a lot of different things 😄
./gradlew build
passed without any errors.