afterOpen hook test

angrykoala · Oct 13, 2018 · 384e773 · 384e773
1 parent 905244b
commit 384e773
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -1274,7 +1274,7 @@ class MyPlugin {
         // not on any page loading
     }
 
-    _afterOpen() { // This hook will be called after the page is opened and _loaded
+    _afterOpen() { // This hook will be called after the page is opened and loaded
         // You can use this hook to start performing actions with evaluate or
         // adding custom scripts with this._browser.page.addScriptTag
     }

diff --git a/tests/browser/plugins.test.js b/tests/browser/plugins.test.js
@@ -12,6 +12,7 @@ describe("Plugins", () => {
             this.browser = browser;
             this.beforeOpenCalled = false;
             this.beforeCloseCalled = false;
+            this.afterOpenCalled = false;
         }
 
         myMethod() {
@@ -25,6 +26,10 @@ describe("Plugins", () => {
         _beforeClose() {
             this.beforeCloseCalled = true;
         }
+
+        _afterOpen() {
+            this.afterOpenCalled = true;
+        }
     }
 
     class AssertionPluginTest {
@@ -78,8 +83,10 @@ describe("Plugins", () => {
         assert.ok(browser.pluginTest);
         assert.strictEqual(browser.pluginTest.beforeOpenCalled, false);
         assert.strictEqual(browser.pluginTest.beforeCloseCalled, false);
+        assert.strictEqual(browser.pluginTest.afterOpenCalled, false);
         await browser.open(configUrls.index);
         assert.strictEqual(browser.pluginTest.beforeOpenCalled, true);
+        assert.strictEqual(browser.pluginTest.afterOpenCalled, true);
         assert.strictEqual(browser.pluginTest.beforeCloseCalled, false);
         await browser.close();
         assert.strictEqual(browser.pluginTest.beforeCloseCalled, true);