Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Karma tests failing #13

Closed
ProLoser opened this issue Oct 19, 2015 · 5 comments
Closed

Karma tests failing #13

ProLoser opened this issue Oct 19, 2015 · 5 comments

Comments

@ProLoser
Copy link
Member

@kasperlewau I am not sure why these tests are failing:

PhantomJS 1.9.8 (Mac OS X 0.0.0) uiMentionController on invocation "before each" hook for "exposes a pattern" FAILED
    TypeError: 'undefined' is not a function (near '...}).bind(this);...')
        at /Users/Dean/Sites/ui-mention/src/mentionController.es6.js:310
        at invoke (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4478)
        at instantiate (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4486)
        at /Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:9151
        at /Users/Dean/Sites/ui-mention/node_modules/angular-mocks/angular-mocks.js:1882
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:29
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:41
PhantomJS 1.9.8 (Mac OS X 0.0.0) uiMentionController public API "before each" hook for "init is a public API method on undefined" FAILED
    TypeError: 'undefined' is not a function (near '...}).bind(this);...')
        at /Users/Dean/Sites/ui-mention/src/mentionController.es6.js:310
        at invoke (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4478)
        at instantiate (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4486)
        at /Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:9151
        at /Users/Dean/Sites/ui-mention/node_modules/angular-mocks/angular-mocks.js:1882
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:29
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:68
PhantomJS 1.9.8 (Mac OS X 0.0.0) uiMentionController DOM listeners "before each" hook for "sets moved to false if moved is truthy" FAILED
    TypeError: 'undefined' is not a function (near '...}).bind(this);...')
        at /Users/Dean/Sites/ui-mention/src/mentionController.es6.js:310
        at invoke (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4478)
        at instantiate (/Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:4486)
        at /Users/Dean/Sites/ui-mention/node_modules/angular/angular.js:9151
        at /Users/Dean/Sites/ui-mention/node_modules/angular-mocks/angular-mocks.js:1882
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:29
        at /Users/Dean/Sites/ui-mention/test/uiMentionController.spec.js:387

That line number is a comment.

@kasperlewau
Copy link
Contributor

Oh hey, some time ago!

I'll take a look in a jiffy.

@kasperlewau
Copy link
Contributor

Hmm. Running the test suite locally on [email protected] as well as [email protected] throws no errors on my end - [email protected] throws a segmentation error.

@kasperlewau
Copy link
Contributor

Bah - it probably has to do with my PhantomJS version set to 2.0.0 - where .bind is supported.

PhantomJS < 2.0.0 needs a .bind polyfill, as far as I know.

Would you like for me to submit a PR that includes the following polyfill at MDN in the test suite?

@ProLoser
Copy link
Member Author

👍 @kasperlewau you are once again the man. Let me know if you'd have any interest being added to this project as a collaborator.

@kasperlewau
Copy link
Contributor

@ProLoser Being added as a collaborator sounds a lot more in line with my current situation, more so than becoming the maintainer - fire away 😄!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants