This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Fix/broken phantom tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions prior to 2.0.0 are based on a version of WebkitQT that does not support Fn.proto.bind.
Did not add value to the specs, and they broke on PhantomJS versions lower than 2.0.
|
cc @ProLoser |
|
Awesome, now all we gotta do is add a travis file |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn.proto.bindpolyfill for PhantomJS < 2.0.new Eventcalls.The tldr version of it all is that I made a boo-boo and ran all the tests on PhantomJS 2.0, which isn't shipped with the
karma-phantomjs-launcherpackage, nor is it released on npm.Closes #13