Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration url #67

Open
wants to merge 2 commits into
base: yang-issues
Choose a base branch
from
Open

Configuration url #67

wants to merge 2 commits into from

Conversation

mcr
Copy link
Member

@mcr mcr commented Oct 4, 2024

rename attribute. close #50

@mcr mcr requested review from stfries and removed request for pritikin, toerless and QiufangMa October 4, 2024 16:30
@mcr mcr changed the base branch from main to yang-issues October 4, 2024 16:31
@stfries
Copy link
Collaborator

stfries commented Oct 7, 2024

BRSKI-PRM does not use this component of the voucher. So it should not provide problems as we look for known and used values of BRSKI-PRM. It is defined and used in BRSKI-Cloud and likely affects implementations using the component additional-configuration.

In general as it is an optional value, the explaining text in RFC 8366bis should state "This node is optional because it is not used by all bootstrapping protocols." as for instance for the nonce leaf of the voucher.

While thinking about the naming, maybe "additional-manufacturer-configuration-uri" is more specific as the leaf description states the relation to the vendor/manufacturer. BTW, maybe it is better to call it manufacturer in the description instead of vendor.

Two further thoughts regarding this:

  • In general in RFC8366bis there should be a statement that unknown values or leafs in the voucher or voucher request should be ignored by the implementation.
  • Nevertheless, the additional-configuration-url in general could also be interesting for BRSKI, BRSKI-PRM, or BRSKI-AE if it would be included in the registrar-voucher-request (as domain local URL) and populated in the voucher by the MASA. That way the pledge could get information where to find a configuration server in the registrar's domain. But this is just a thought. Maybe it is better to define such functionality via an additional leaf as the description of the additional-configuration-uri is set by the vendor/manufacturer (as stated in the description).

@mcr
Copy link
Member Author

mcr commented Oct 8, 2024 via email

@mcr mcr requested a review from upros October 8, 2024 17:44
Copy link

@upros upros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as is, but Steffen's comment about using term manufacturer instead of vendor seems ok too.

Copy link
Collaborator

@stfries stfries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in general is fine. What is open from my perspective are the following points:

  • As it is an optional value, the explaining text in RFC 8366bis should state "This node is optional because it is not used by all bootstrapping protocols." as for instance for the nonce leaf of the voucher.
  • Would a further optional value "additional-operator-configuration-uri" be beneficial to allow for populating a domain local configuration uri or mDNS name? In that case it would be good to rename the current "additional-configuration-uri" to "additional-manufacturer-configuration-uri"

@mcr
Copy link
Member Author

mcr commented Oct 15, 2024 via email

@stfries
Copy link
Collaborator

stfries commented Oct 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify additional configuration info
3 participants