Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fxgcppubsub): Added nack reactor #22

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

ekkinox
Copy link
Contributor

@ekkinox ekkinox commented Jul 10, 2024

No description provided.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (75a8ca9) to head (0431c3d).

❗ There is a different number of reports uploaded between BASE (75a8ca9) and HEAD (0431c3d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (75a8ca9) HEAD (0431c3d)
fxslack 1 0
fxredis 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
- Coverage   94.82%   83.96%   -10.87%     
===========================================
  Files           2       28       +26     
  Lines          58      842      +784     
===========================================
+ Hits           55      707      +652     
- Misses          2      101       +99     
- Partials        1       34       +33     
Flag Coverage Δ
fxgcppubsub 83.96% <100.00%> (?)
fxredis ?
fxslack ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xvzf xvzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@ekkinox ekkinox merged commit 3cae2a1 into main Jul 10, 2024
6 checks passed
@ekkinox ekkinox deleted the feat/fxgcppubsub-nack branch July 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants