feat: POC RNF #751
Draft
feat: POC RNF #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johangirod
approved these changes
Nov 2, 2023
Comment on lines
+322
to
+324
| constructor(public message: string) { | ||
| super(); | ||
| } |
There was a problem hiding this comment.
I think you can omit the constructor...
Comment on lines
49
to
60
| exception instanceof NotASiretError | ||
| ) { | ||
| return redirectPageNotFound(message, scope); | ||
| } else if (exception instanceof IsLikelyAnIdRnfException) { | ||
| return redirectIfIdRnf(message); | ||
| } else if (exception instanceof NotAnIdRnfError) { | ||
| return redirectIdRnfInvalid(message); | ||
| } else if (exception instanceof RnfNotFoundError) { | ||
| return redirectIdRnfIntrouvable(message); | ||
| } else if (exception instanceof HttpNotFound) { | ||
| return redirectPageNotFound(message, scope); | ||
| } else if (exception instanceof SearchEngineError) { |
There was a problem hiding this comment.
It's a bit weird for me to use exception in that case. I'm not sure it should be handled as such, but instead, a well crafted type return type and a switch case in the top of the route. But this is outside of the scope of this PR
Co-authored-by: Johan Girod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The MI is currently working on a new DB called RNF (Répertoire National des Fondations).
They needs a platform to :
Current scope
First implementation of RNF :
/fondation/<ID_RNF>075-FDD-00003-01Next steps :
Invalid/Not foundworkflowscloses #731