Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify appropriate version(s) of Tendermint in a machine readable format in the repo #153

Closed
james-chf opened this issue Jul 5, 2022 · 4 comments
Closed

Specify appropriate version(s) of Tendermint in a machine readable format in the repo #153

james-chf opened this issue Jul 5, 2022 · 4 comments
Assignees
@tzemanovic @Fraccaman
Labels
good first issue Good for newcomers ledger
Milestone
Later / optional

Comments

@james-chf
Copy link
Contributor

james-chf commented Jul 5, 2022 •
edited
Loading

We should specify at least one Tendermint version we are definitely compatible in our repo in a machine friendly way. Then given any commit of namada, it should be easy to see a version of tendermint that can definitely be used. This could be a simple tendermint-version file that simply has a tag/ref of the Tendermint version we are using by default, or something more advanced like a .toml that specifies the versions to be used with different feature flags.

e.g. in eth-bridge-integration

[default]
git = "https://github.com/tendermint/tendermint.git"  # default
ref = "v0.37.0-alpha.2"
cargo_default_features = true  # default
cargo_extra_features = []  # default

[abcipp]
git = "https://github.com/heliaxdev/tendermint.git"
ref = "v0.1.1-abcipp"
cargo_default_features = false
cargo_extra_features = [ "abcipp" ]

e.g. in main (until that also switches to v0.37)

[default]
git = "https://github.com/heliaxdev/tendermint.git"
ref = "v0.1.1-abcipp"
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@james-chf james-chf added the good first issue Good for newcomers label Jul 13, 2022
@james-chf james-chf mentioned this issue Jul 19, 2022
Open
@james-chf james-chf changed the title Specify compatible tendermint versions in anoma repo Specify compatible Tendermint version(s) in the codebase Jul 19, 2022
@james-chf james-chf changed the title Specify compatible Tendermint version(s) in the codebase Specify compatible Tendermint version(s) in the codebase in a machine readable format Sep 6, 2022
@james-chf james-chf moved this to Todo in Namada-Old Sep 20, 2022
@james-chf
Copy link
Contributor Author

From #437 (comment) for eth-bridge-integration

With the abcipp feature flag enabled, test this PR with this Tendermint version:
https://github.com/heliaxdev/tendermint/releases/tag/v0.1.1-abcipp

Otherwise, use this version:
https://github.com/tendermint/tendermint/tree/0b58342a46b1917a40d506e48e87448dcc8b3131

@james-chf james-chf self-assigned this Sep 27, 2022
@james-chf james-chf changed the title Specify compatible Tendermint version(s) in the codebase in a machine readable format Update scripts/install/get_tendermint.sh to install an appropriate version of Tendermint Sep 27, 2022
@james-chf james-chf changed the title Update scripts/install/get_tendermint.sh to install an appropriate version of Tendermint Update scripts/install/get_tendermint.sh to install an appropriate version of Tendermint v0.37 Sep 27, 2022
@james-chf
Copy link
Contributor Author

james-chf commented Sep 28, 2022 •
edited
Loading

If we start using a stable(ish) version of Tendermint, it might just be easier to get rid of scripts/install/get_tendermint.sh altogether and point users to where to get/install Tendermint from in our README.md.

@james-chf james-chf changed the title Update scripts/install/get_tendermint.sh to install an appropriate version of Tendermint v0.37 Specify appropriate version(s) of Tendermint in a machine readable format in the repo Sep 28, 2022
@james-chf james-chf mentioned this issue Sep 28, 2022
Closed
@james-chf james-chf removed their assignment Oct 11, 2022
@tzemanovic
Copy link
Member

related to #525

phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@jurevans
feat/140 - Multi-chain configurations (anoma#153)
066b67b 
* Adding chain config types, and several default chain configs

* Minor adjustments to config

* Hook namada-interface up to new chains config and type

* Update integrations to incorporate new chain config

* Add common interface for integrations

* Continue refactoring for new configs, removing old config

* clean up, remove old IBC config, correctly pull chain config

* Update extension to utlize shared config properly

* Finish extension config, continue integration with namada-interface

* Fix initialization of Anoma extension in context

* Add ability to override chain configs via .env

* Map Keplr accounts to our Account type to support state

* Minor clean-up

* Provide .env variables to extension to override defaults

* Just adding some comments to webpack config

* Update defaults to real URLs in chain configs, comments

* Updated webpack to fix issue with missing quotes in build

* Very minor fix
@tzemanovic tzemanovic added this to the Later / optional milestone May 24, 2024
@Fraccaman
Copy link
Member

closing in favor of #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

@Fraccaman Fraccaman

Labels
good first issue Good for newcomers ledger
Projects
No open projects
Namada-Old
Status: Todo
Milestone
Later / optional
Development

No branches or pull requests
3 participants
@tzemanovic @Fraccaman @james-chf