Merge pull request spring-projects#15791 from Christoph Dreis

* spring-projectsgh-15791: Polish "Test the Gradle plugin against Gradle 4.10.3 and 5.1.1" Test the Gradle plugin against Gradle 4.10.3 and 5.1.1
anshuman-mor · Feb 11, 2019 · c00dc42 · c00dc42
2 parents 26da45a + 4faa0f5
commit c00dc42
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/...-plugin/src/test/java/org/springframework/boot/gradle/junit/GradleCompatibilitySuite.java b/...-plugin/src/test/java/org/springframework/boot/gradle/junit/GradleCompatibilitySuite.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2018 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@
 public final class GradleCompatibilitySuite extends Suite {
 
 	private static final List<String> GRADLE_VERSIONS = Arrays.asList("default", "4.5.1",
-			"4.6", "4.7", "4.8.1", "4.9", "4.10.2", "5.0");
+			"4.6", "4.7", "4.8.1", "4.9", "4.10.3", "5.0", "5.1.1");
 
 	public GradleCompatibilitySuite(Class<?> clazz) throws InitializationError {
 		super(clazz, createRunners(clazz));

diff --git a/.../test/java/org/springframework/boot/gradle/plugin/KotlinPluginActionIntegrationTests.java b/.../test/java/org/springframework/boot/gradle/plugin/KotlinPluginActionIntegrationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2018 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -43,12 +43,10 @@ public void noKotlinVersionPropertyWithoutKotlinPlugin() {
 	}
 
 	@Test
-	public void kotlinVersionMatchesKotlinPluginVersion() {
+	public void kotlinVersionPropertyIsSet() {
 		String output = this.gradleBuild.build("kotlinVersion", "dependencies",
 				"--configuration", "compileClasspath").getOutput();
-		assertThat(output).contains("Kotlin version: 1.2.20");
-		assertThat(output)
-				.containsPattern("org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.2.20");
+		assertThat(output).containsPattern("Kotlin version: [0-9]\\.[0-9]\\.[0-9]+");
 	}
 
 	@Test

diff --git a/...boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/testkit/GradleBuild.java b/...boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/testkit/GradleBuild.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2018 the original author or authors.
+ * Copyright 2012-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -195,7 +195,7 @@ public GradleRunner prepareRunner(String... arguments) throws IOException {
 			gradleRunner.withGradleVersion(this.gradleVersion);
 		}
 		else if (this.dsl == Dsl.KOTLIN) {
-			gradleRunner.withGradleVersion("4.10.2");
+			gradleRunner.withGradleVersion("4.10.3");
 		}
 		List<String> allArguments = new ArrayList<>();
 		allArguments.add("-PbootVersion=" + getBootVersion());

diff --git a/...nVersionMatchesKotlinPluginVersion.gradle → ...onTests-kotlinVersionPropertyIsSet.gradle b/...nVersionMatchesKotlinPluginVersion.gradle → ...onTests-kotlinVersionPropertyIsSet.gradle