Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding become to service restarts #571

Merged
merged 1 commit into from
Feb 22, 2024
Merged

adding become to service restarts #571

merged 1 commit into from
Feb 22, 2024

Conversation

hallaj
Copy link
Contributor

@hallaj hallaj commented Nov 9, 2023

Adding explicit become here. My current play seems to be failing if I my actual playbook has become: false and only having the become: true within import_role

The following works:

- hosts: target
  become: true
  role: [ansible-consul]

I'm failing with this, unless the changes proposed gets applied:

- hosts: target
  become: false
  tasks:
    - name: Import role
      become: true
      import_role:
        name: ansible-consul

@nre-ableton
Copy link
Contributor

CI is now fixed, can you please rebase and fix the conflicts?

bbaassssiiee
bbaassssiiee previously requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@bbaassssiiee bbaassssiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase & resolve conflicts.

@hallaj
Copy link
Contributor Author

hallaj commented Jan 16, 2024

@nre-ableton @bbaassssiiee Rebased and fixed the conflicts.

@bbaassssiiee
Copy link
Member

Seems there is more work in progress in CI.

@nre-ableton
Copy link
Contributor

@hallaj CI is fixed, sorry about that. 😅 Can you please rebase again?

@hallaj
Copy link
Contributor Author

hallaj commented Feb 21, 2024

@nre-ableton Rebased ;)

nre-ableton
nre-ableton approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍

@nre-ableton nre-ableton dismissed bbaassssiiee’s stale review February 22, 2024 08:58

Conflicts have been fixed and CI is green.

@nre-ableton nre-ableton merged commit 5243f1b into ansible-collections:master Feb 22, 2024
16 checks passed
isakrubin added a commit to car-info/ansible-consul that referenced this pull request Jun 10, 2024
@isakrubin
Merge remote-tracking branch 'upstream/master'
053901c 
* upstream/master:
  Remove deprecated molecule/centos-stream-8
  Fix rolling restart by waiting for consul leave and after restart
  Update molecule.yml
  --- (ansible-collections#597)
  Bump idna from 3.3 to 3.7 in the pip group across 1 directory (ansible-collections#596)
  Fix CI badge in README (ansible-collections#595)
  Fix ubuntu 22.04 molecule test to actually run on 22.04 (ansible-collections#594)
  feat: Configuration validation. fix ansible-collections#518 (ansible-collections#592)
  Fix error when creating gossip key (ansible-collections#558)
  adding become to service restarts (ansible-collections#571)
  Bump the pip group across 1 directories with 1 update (ansible-collections#590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nre-ableton nre-ableton nre-ableton approved these changes

@bbaassssiiee bbaassssiiee bbaassssiiee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hallaj @nre-ableton @bbaassssiiee